Skip to content
Permalink
Browse files
Include transform in OUTER_PROPS (#26611)
Summary:
Without `transform` in `OUTER_PROPS`, the refresh control component would not include `transform: {scaleY: -1}` in its style and so pulling down, rather than up, on a scroll view would trigger a refresh.

Fixes #26181

## Changelog
[Android] [Fixed] - Fixed issue with refresh control not working properly on an inverted ScrollView
Pull Request resolved: #26611

Test Plan: Updated unit test in splitLayoutProps-test.js.

Differential Revision: D17661079

Pulled By: cpojer

fbshipit-source-id: 747da27b11c3ca59b7f639f393ae5ac137f5490a
  • Loading branch information
migbot authored and facebook-github-bot committed Sep 30, 2019
1 parent 9a2bc71 commit 0a282c42b4d1c2316513cd5588a0a92b54db2991
Showing 2 changed files with 5 additions and 1 deletion.
@@ -13,11 +13,14 @@
const splitLayoutProps = require('../splitLayoutProps');

test('splits style objects', () => {
const style = {width: 10, margin: 20, padding: 30};
const style = {width: 10, margin: 20, padding: 30, transform: {scaleY: -1}};
const {outer, inner} = splitLayoutProps(style);
expect(outer).toMatchInlineSnapshot(`
Object {
"margin": 20,
"transform": Object {
"scaleY": -1,
},
"width": 10,
}
`);
@@ -36,6 +36,7 @@ const OUTER_PROPS = Object.assign(Object.create(null), {
right: true,
bottom: true,
top: true,
transform: true,
});

function splitLayoutProps(

0 comments on commit 0a282c4

Please sign in to comment.