Skip to content
Permalink
Browse files

Add extensibility point on react-native-xcode.sh script

Summary:
Original pull request: #12863

Useful for generating source maps, for example.

Feature parity with Android, that already have this extensibility point on `build.gradle`:
```
project.ext.react = [
    extraPackagerArgs: [...]
]
```

Xcode > Build Phases > Bundle React Native code and Images
```
export NODE_BINARY=node
export EXTRA_PACKAGER_ARGS="--sourcemap-output ${SRCROOT}/build/main.jsbundle.map"
../node_modules/react-native/scripts/react-native-xcode.sh
```

[IOS] [FEATURE] [./react-native-xcode.sh] - Added $EXTRA_PACKAGER_ARGS extensibility point
Closes #16933

Differential Revision: D6771709

Pulled By: yungsters

fbshipit-source-id: a33614b45b1e3537daeb31504fdd3a402dc70ff0
  • Loading branch information...
brunolemos authored and facebook-github-bot committed Jan 22, 2018
1 parent bcfbdf4 commit 0d4ff1b7ea768cceca0405c665e322c0d6b5ba20
Showing with 0 additions and 129 deletions.
  1. +0 −129 scripts/react-native-xcode.sh

This file was deleted.

Oops, something went wrong.

3 comments on commit 0d4ff1b

@chirag04

This comment has been minimized.

Copy link
Collaborator

chirag04 replied Jan 22, 2018

@hramos original PR was to change something. seems like the import deleted the entire file.

@brunolemos

This comment has been minimized.

Copy link
Contributor Author

brunolemos replied Jan 23, 2018

Yep cc @yungsters.
The PR is just one line change, not idea why this happened when the bot imported.

PS: although the first line says PR 12683 the correct one is #16933.

@yungsters

This comment has been minimized.

Copy link
Contributor

yungsters replied Jan 23, 2018

See b8c86b8.

Please sign in to comment.
You can’t perform that action at this time.