Permalink
Browse files

Don't block scroll when using non-touchable visible row for SwipeableRow

Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes #8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
  • Loading branch information...
1 parent a2c6a7b commit 13a19a8897b4d96b9dfbee5640451d6913a4f44c @chirag04 chirag04 committed with Facebook Github Bot 3 Jul 11, 2016
Showing with 0 additions and 4 deletions.
  1. +0 −4 Libraries/Experimental/SwipeableRow/SwipeableRow.js
@@ -128,10 +128,6 @@ const SwipeableRow = React.createClass({
componentWillMount(): void {
this._panResponder = PanResponder.create({
- onStartShouldSetPanResponder: (event, gestureState) => true,
- // Don't capture child's start events
- onStartShouldSetPanResponderCapture: (event, gestureState) => false,
- onMoveShouldSetPanResponder: (event, gestureState) => false,
onMoveShouldSetPanResponderCapture: this._handleMoveShouldSetPanResponderCapture,
onPanResponderGrant: this._handlePanResponderGrant,
onPanResponderMove: this._handlePanResponderMove,

0 comments on commit 13a19a8

Please sign in to comment.