From 13a2b117becd7bfb983080a330149362ebed8816 Mon Sep 17 00:00:00 2001 From: Paige Sun Date: Mon, 18 Jul 2022 15:19:53 -0700 Subject: [PATCH] Minor: Rename AccessibilityInfo.sendAccessibilityEvent_unstable to sendAccessibilityEvent Summary: Changelog: [Internal] Rename AccessibilityInfo.sendAccessibilityEvent_unstable to sendAccessibilityEvent In Fabric, we want people to use `AccessibilityInfo.sendAccessibilityEvent` instead of `UIManager.sendAccessibilityEvent` for Android. The API is not unstable. There is a test in [AccessibilityExample.js](https://github.com/facebook/react-native/blob/c940eb0c49518b82a3999dcac3027aa70018c763/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js#L959) in RNTester to confirm that it works. A search for [`AccessibilityInfo.sendAccessibilityEvent_unstable` in Github](https://github.com/search?q=AccessibilityInfo.sendAccessibilityEvent_unstable&type=Code) shows that it's not being used yet, which makes sense because it's an Fabric API. Therefore it's safe to rename it. Reviewed By: sammy-SC Differential Revision: D37901006 fbshipit-source-id: 73f35b09ca8f9337f4d66a431f0a3f815da38249 --- Libraries/Components/AccessibilityInfo/AccessibilityInfo.js | 2 +- Libraries/ReactNative/BridgelessUIManager.js | 2 +- jest/setup.js | 2 +- .../rn-tester/js/examples/Accessibility/AccessibilityExample.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js b/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js index 6a286096510aca..1f116ddcf1795e 100644 --- a/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js +++ b/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js @@ -345,7 +345,7 @@ const AccessibilityInfo: AccessibilityInfoType = { /** * Send a named accessibility event to a HostComponent. */ - sendAccessibilityEvent_unstable( + sendAccessibilityEvent( handle: ElementRef>, eventType: AccessibilityEventTypes, ) { diff --git a/Libraries/ReactNative/BridgelessUIManager.js b/Libraries/ReactNative/BridgelessUIManager.js index 0b959568a372de..3347b6a91bc47c 100644 --- a/Libraries/ReactNative/BridgelessUIManager.js +++ b/Libraries/ReactNative/BridgelessUIManager.js @@ -146,7 +146,7 @@ module.exports = { errorMessageForMethod('setLayoutAnimationEnabledExperimental'), ); }, - // Please use AccessibilityInfo.sendAccessibilityEvent_unstable instead. + // Please use AccessibilityInfo.sendAccessibilityEvent instead. // See SetAccessibilityFocusExample in AccessibilityExample.js for a migration example. sendAccessibilityEvent: (reactTag: ?number, eventType: number): void => console.error(errorMessageForMethod('sendAccessibilityEvent')), diff --git a/jest/setup.js b/jest/setup.js index 7a00753ca520dd..e2809554db1b44 100644 --- a/jest/setup.js +++ b/jest/setup.js @@ -133,7 +133,7 @@ jest isScreenReaderEnabled: jest.fn(() => Promise.resolve(false)), removeEventListener: jest.fn(), setAccessibilityFocus: jest.fn(), - sendAccessibilityEvent_unstable: jest.fn(), + sendAccessibilityEvent: jest.fn(), getRecommendedTimeoutMillis: jest.fn(), }, })) diff --git a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js index 0ba7b074e5f2f3..30ad9d64891541 100644 --- a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js +++ b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js @@ -956,7 +956,7 @@ function SetAccessibilityFocusExample(props: {}): React.Node { const onPress = () => { if (myRef && myRef.current) { - AccessibilityInfo.sendAccessibilityEvent_unstable(myRef.current, 'focus'); + AccessibilityInfo.sendAccessibilityEvent(myRef.current, 'focus'); } };