Permalink
Browse files

Implement 'scrollEnabled' prop

Summary:
@public

The content of `WKWebView` renders within a scrollview. In this diff, I'm introducing the prop `scrollEnabled` to allow developers to control whether scrolling is enabled within the scroll view, or not.

Reviewed By: mmmulani

Differential Revision: D6307001

fbshipit-source-id: 5a199c6c3b8535e45a5a3cb6041e822bb7af2362
  • Loading branch information...
RSNara authored and kelset committed Aug 16, 2018
1 parent 06cce04 commit 1c3af598b163c8e02baa0bfa3455347ed869932f
Showing with 9 additions and 0 deletions.
  1. +1 −0 React/Views/RCTWKWebView.h
  2. +5 −0 React/Views/RCTWKWebView.m
  3. +3 −0 React/Views/RCTWKWebViewManager.m
@@ -20,6 +20,7 @@
@property (nonatomic, copy) NSDictionary *source;
@property (nonatomic, assign) BOOL messagingEnabled;
@property (nonatomic, copy) NSString *injectedJavaScript;
@property (nonatomic, assign) BOOL scrollEnabled;
- (void)postMessage:(NSString *)message;
@@ -85,6 +85,11 @@ - (void)setSource:(NSDictionary *)source
}
}
- (void)setScrollEnabled:(BOOL)scrollEnabled
{
_webView.scrollView.scrollEnabled = scrollEnabled;
}
- (void)postMessage:(NSString *)message
{
NSDictionary *eventInitDict = @{@"data": message};
@@ -37,5 +37,8 @@ - (UIView *)view
}
RCT_REMAP_VIEW_PROPERTY(bounces, _webView.scrollView.bounces, BOOL)
RCT_CUSTOM_VIEW_PROPERTY(scrollEnabled, BOOL, RCTWKWebView) {
view.scrollEnabled = json == nil ? true : [RCTConvert BOOL: json];
}
@end

0 comments on commit 1c3af59

Please sign in to comment.