Skip to content
Permalink
Browse files

Move WebView Android files to FB internal

Summary: This moves the Java files to FB internal and updates all the buck files

Reviewed By: TheSavior

Differential Revision: D14622521

fbshipit-source-id: a8d293e9f9e08868cca3ed2986a08d0db16dec15
  • Loading branch information...
cpojer authored and facebook-github-bot committed Apr 2, 2019
1 parent 556aa93 commit 1ca9a9553763a89c977f756b45486f8b9cedab80
@@ -62,7 +62,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/views/toolbar:toolbar"),
react_native_target("java/com/facebook/react/views/view:view"),
react_native_target("java/com/facebook/react/views/viewpager:viewpager"),
react_native_target("java/com/facebook/react/views/webview:webview"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("res:shell"),
],
@@ -62,7 +62,6 @@
import com.facebook.react.views.toolbar.ReactToolbarManager;
import com.facebook.react.views.view.ReactViewManager;
import com.facebook.react.views.viewpager.ReactViewPagerManager;
import com.facebook.react.views.webview.ReactWebViewManager;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
@@ -337,7 +336,6 @@ public NativeModule get() {
viewManagers.add(new ReactSliderManager());
viewManagers.add(new ReactSwitchManager());
viewManagers.add(new ReactToolbarManager());
viewManagers.add(new ReactWebViewManager());
viewManagers.add(new SwipeRefreshLayoutManager());

// Native equivalents
@@ -129,7 +129,7 @@ protected void onAfterUpdateTransaction(@Nonnull T view) {
/**
* Subclasses may use this method to receive events/commands directly from JS through the
* {@link UIManager}. Good example of such a command would be {@code scrollTo} request with
* coordinates for a {@link ScrollView} or {@code goBack} request for a {@link WebView} instance.
* coordinates for a {@link ScrollView} instance.
*
* @param root View instance that should receive the command
* @param commandId code of the command
@@ -144,18 +144,6 @@ public void receiveCommand(@Nonnull T root, int commandId, @Nullable ReadableArr
* map between names of the commands and IDs that are then used in {@link #receiveCommand} method
* whenever the command is dispatched for this particular {@link ViewManager}.
*
* As an example we may consider {@link ReactWebViewManager} that expose the following commands:
* goBack, goForward, reload. In this case the map returned from {@link #getCommandsMap} from
* {@link ReactWebViewManager} will look as follows:
* {
* "goBack": 1,
* "goForward": 2,
* "reload": 3,
* }
*
* Now assuming that "reload" command is dispatched through {@link UIManagerModule} we trigger
* {@link ReactWebViewManager#receiveCommand} passing "3" as {@code commandId} argument.
*
* @return map of string to int mapping of the expected commands
*/
public @Nullable Map<String, Integer> getCommandsMap() {

This file was deleted.

0 comments on commit 1ca9a95

Please sign in to comment.
You can’t perform that action at this time.