Permalink
Browse files

packager: TerminalReporter: stop reporting global cache errors

Summary: At FB we log errors into the error infra, and these errors are not actionnable for end users, so let's reduce the noise generated on the terminal. In the OSS case, people can simply add a handler in a TerminalReporter decorator, the same way we do internally (anyhow, I do not know of anyone using the global cache in OSS for now).

Reviewed By: davidaurelio

Differential Revision: D4762858

fbshipit-source-id: 880c02e175ae551df11b7ce273acc318222c46bf
  • Loading branch information...
jeanlauliac authored and facebook-github-bot committed Mar 23, 2017
1 parent dcf3cbe commit 20ba9871390be44b998a56e264a3dfd3b4582789
Showing with 0 additions and 4 deletions.
  1. +0 −4 packager/src/lib/TerminalReporter.js
@@ -148,10 +148,6 @@ class TerminalReporter {
case 'dep_graph_loaded':
terminal.log(`${DEP_GRAPH_MESSAGE}, done.`);
break;
case 'global_cache_error':
const message = JSON.stringify(event.error.message);
reporting.logWarning(terminal, 'the global cache failed: %s', message);
break;
case 'global_cache_disabled':
this._logCacheDisabled(event.reason);
break;

0 comments on commit 20ba987

Please sign in to comment.