Skip to content
Permalink
Browse files

Fix HMR syntax error messages (`message` instead of `description`)

Summary:
The code to display HMR errors on the client was reading the `description` field from Metro payloads. Metro does not include `description` in the body of its error payloads -- only in its `body.errors[]` items. This commit changes RN's HMR code to show `body.message` (set consistently with facebook/metro#124) instead of the non-existent `body.description`.

Open a test RN app, enable HMR, and then introduce a syntax error in an app source file. See that the redbox provides information about the syntax error instead of just saying "TransformError undefined".

- facebook/metro#124

[GENERAL][ENHANCEMENT][HMR] - Fix display of syntax error messages when HMR is enabled
Closes #17619

Differential Revision: D6726516

Pulled By: mjesun

fbshipit-source-id: b1d1008d6f1aa8f88ff8a2aa1374724a305c773b
  • Loading branch information...
ide authored and facebook-github-bot committed Jan 16, 2018
1 parent 6bb8617 commit 2b80cdf1bba3b756915117139474440c203cbd8d
Showing with 1 addition and 1 deletion.
  1. +1 −1 Libraries/Utilities/HMRClient.js
@@ -121,7 +121,7 @@ Error: ${e.message}`
}
case 'error': {
HMRLoadingView.hide();
throw new Error(data.body.type + ' ' + data.body.description);
throw new Error(`${data.body.type}: ${data.body.message}`);
}
default: {
throw new Error(`Unexpected message: ${data}`);

0 comments on commit 2b80cdf

Please sign in to comment.
You can’t perform that action at this time.