Permalink
Browse files

Add ?Fbt to flow type for the title & message props

Differential Revision: D6253195

fbshipit-source-id: eadb185eacdf341393d73357beab22bed1d0169e
  • Loading branch information...
Jessica Cao authored and facebook-github-bot committed Nov 7, 2017
1 parent 515eb0e commit 2be3ae1ff2441c0ee3f2b9255c23dc49ada852fe
Showing with 12 additions and 9 deletions.
  1. +5 −4 Libraries/Alert/Alert.js
  2. +7 −5 Libraries/Alert/AlertIOS.js
@@ -16,6 +16,7 @@ const NativeModules = require('NativeModules');
const Platform = require('Platform');
import type { AlertType, AlertButtonStyle } from 'AlertIOS';
import type { Fbt } from 'fbt';

This comment has been minimized.

@chirag04

chirag04 Nov 8, 2017

Collaborator

@hramos we need to add this to package.json?

This comment has been minimized.

@hramos

hramos Nov 9, 2017

Contributor

Hmm let me follow up.

export type Buttons = Array<{
text?: string,
@@ -79,8 +80,8 @@ type Options = {
class Alert {
static alert(
title: ?string,
message?: ?string,
title: ?string | ?Fbt,
message?: ?string | ?Fbt,
buttons?: Buttons,
options?: Options,
type?: AlertType,
@@ -104,8 +105,8 @@ class Alert {
class AlertAndroid {
static alert(
title: ?string,
message?: ?string,
title: ?string | ?Fbt,
message?: ?string | ?Fbt,
buttons?: Buttons,
options?: Options,
): void {
@@ -12,7 +12,9 @@
*/
'use strict';
var RCTAlertManager = require('NativeModules').AlertManager;
const RCTAlertManager = require('NativeModules').AlertManager;
import type { Fbt } from 'fbt';
/**
* An Alert button type
@@ -133,8 +135,8 @@ class AlertIOS {
* );
*/
static alert(
title: ?string,
message?: ?string,
title: ?string | ?Fbt,
message?: ?string | ?Fbt,
callbackOrButtons?: ?(() => void) | ButtonsArray,
type?: AlertType,
): void {
@@ -192,8 +194,8 @@ class AlertIOS {
* );
*/
static prompt(
title: ?string,
message?: ?string,
title: ?string | ?Fbt,
message?: ?string | ?Fbt,
callbackOrButtons?: ?((text: string) => void) | ButtonsArray,
type?: ?AlertType = 'plain-text',
defaultValue?: string,

0 comments on commit 2be3ae1

Please sign in to comment.