From 2be3ae1ff2441c0ee3f2b9255c23dc49ada852fe Mon Sep 17 00:00:00 2001 From: Jessica Cao Date: Mon, 6 Nov 2017 16:09:52 -0800 Subject: [PATCH] Add ?Fbt to flow type for the title & message props Differential Revision: D6253195 fbshipit-source-id: eadb185eacdf341393d73357beab22bed1d0169e --- Libraries/Alert/Alert.js | 9 +++++---- Libraries/Alert/AlertIOS.js | 12 +++++++----- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/Libraries/Alert/Alert.js b/Libraries/Alert/Alert.js index 40666f70e35076..6598175c0825d3 100644 --- a/Libraries/Alert/Alert.js +++ b/Libraries/Alert/Alert.js @@ -16,6 +16,7 @@ const NativeModules = require('NativeModules'); const Platform = require('Platform'); import type { AlertType, AlertButtonStyle } from 'AlertIOS'; +import type { Fbt } from 'fbt'; export type Buttons = Array<{ text?: string, @@ -79,8 +80,8 @@ type Options = { class Alert { static alert( - title: ?string, - message?: ?string, + title: ?string | ?Fbt, + message?: ?string | ?Fbt, buttons?: Buttons, options?: Options, type?: AlertType, @@ -104,8 +105,8 @@ class Alert { class AlertAndroid { static alert( - title: ?string, - message?: ?string, + title: ?string | ?Fbt, + message?: ?string | ?Fbt, buttons?: Buttons, options?: Options, ): void { diff --git a/Libraries/Alert/AlertIOS.js b/Libraries/Alert/AlertIOS.js index 375a4db56c96a2..933df8512a3b95 100644 --- a/Libraries/Alert/AlertIOS.js +++ b/Libraries/Alert/AlertIOS.js @@ -12,7 +12,9 @@ */ 'use strict'; -var RCTAlertManager = require('NativeModules').AlertManager; +const RCTAlertManager = require('NativeModules').AlertManager; + +import type { Fbt } from 'fbt'; /** * An Alert button type @@ -133,8 +135,8 @@ class AlertIOS { * ); */ static alert( - title: ?string, - message?: ?string, + title: ?string | ?Fbt, + message?: ?string | ?Fbt, callbackOrButtons?: ?(() => void) | ButtonsArray, type?: AlertType, ): void { @@ -192,8 +194,8 @@ class AlertIOS { * ); */ static prompt( - title: ?string, - message?: ?string, + title: ?string | ?Fbt, + message?: ?string | ?Fbt, callbackOrButtons?: ?((text: string) => void) | ButtonsArray, type?: ?AlertType = 'plain-text', defaultValue?: string,