Permalink
Browse files

Fix for scrollview android

Summary:
Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing.

Fixes #16635
the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag'

verify the issue #16635 and tested this fix worked

[ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android.
Closes #18785

Differential Revision: D7569815

Pulled By: hramos

fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
  • Loading branch information...
mistenkt authored and facebook-github-bot committed Apr 10, 2018
1 parent b4c7136 commit 2f1421dec7cd3a35779caceac108e872033c7d72
Showing with 1 addition and 1 deletion.
  1. +1 −1 Libraries/Components/ScrollView/ScrollView.js
@@ -681,7 +681,7 @@ const ScrollView = createReactClass({
}
}
if (Platform.OS === 'android') {
if (this.props.keyboardDismissMode === 'on-drag') {
if (this.props.keyboardDismissMode === 'on-drag' && this.state.isTouching) {
dismissKeyboard();
}
}

0 comments on commit 2f1421d

Please sign in to comment.