Permalink
Browse files

packager: Module: remove too-many-misses codepath

Summary:
This code is a bit sloppy, I need to rethink about it. So I prefer to remove it altogether for now.
The problem with this is that it is disabling the global cache "put" operations at the same time, so the script supposed to update the cache actually doesn't do the job past the fist few hundred files. This defeats the purpose of the global cache.

Reviewed By: cpojer

Differential Revision: D4346927

fbshipit-source-id: 5b668e66b1909f53783772c613781753ac605546
  • Loading branch information...
jeanlauliac authored and facebook-github-bot committed Dec 20, 2016
1 parent 3998650 commit 2f1d1bdfe8b8e02a7cea48aa530c5a120d46233c
Showing with 1 addition and 20 deletions.
  1. +1 −20 packager/react-packager/src/node-haste/Module.js
@@ -31,12 +31,6 @@ import type Cache from './Cache';
import type DependencyGraphHelpers from './DependencyGraph/DependencyGraphHelpers';
import type ModuleCache from './ModuleCache';
/**
* If the global cache returns empty that many times, we give up using the
* global cache for that instance. This speeds up the build.
*/
const GLOBAL_CACHE_MAX_MISSES = 250;
type ReadResult = {
code: string,
dependencies?: ?Array<string>,
@@ -85,7 +79,6 @@ class Module {
_readPromises: Map<string, Promise<ReadResult>>;
static _globalCacheRetries: number;
static _globalCacheMaxMisses: number;
constructor({
file,
@@ -272,8 +265,7 @@ class Module {
) {
const globalCache = GlobalTransformCache.get();
const noMoreRetries = Module._globalCacheRetries <= 0;
const tooManyMisses = Module._globalCacheMaxMisses <= 0;
if (globalCache == null || noMoreRetries || tooManyMisses) {
if (globalCache == null || noMoreRetries) {
this._transformCodeForCallback(cacheProps, callback);
return;
}
@@ -292,19 +284,9 @@ class Module {
}
}
if (globalCachedResult == null) {
--Module._globalCacheMaxMisses;
if (Module._globalCacheMaxMisses === 0) {
this._reporter.update({
type: 'global_cache_disabled',
reason: 'too_many_misses',
});
}
this._transformAndStoreCodeGlobally(cacheProps, globalCache, callback);
return;
}
if (Module._globalCacheMaxMisses < GLOBAL_CACHE_MAX_MISSES) {
++Module._globalCacheMaxMisses;
}
callback(undefined, globalCachedResult);
});
}
@@ -404,7 +386,6 @@ class Module {
}
Module._globalCacheRetries = 4;
Module._globalCacheMaxMisses = GLOBAL_CACHE_MAX_MISSES;
// use weak map to speed up hash creation of known objects
const knownHashes = new WeakMap();

0 comments on commit 2f1d1bd

Please sign in to comment.