Browse files

GLog fix on case sensitive APFS macOS

Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here:

Happy contributing!


This will fix compile error on case sensitive APFS(Apple File System) macs.

Integrate  RN on case sensitive formatted macOS via cocoa pods you will get compile errors on the include lines something like :
1 error generated.

If you change `#include <glog/logging.h>` into `#include <GLog/logging.h>` (replace `glog` with `GLog`) it will fix the build error. After fixing this you will get same kind of errors on a few other places.

[IOS] [BUGFIX] [Framework] - `GLog` fix on case sensitive APFS macOS
Closes #17697

Differential Revision: D6832740

Pulled By: shergin

fbshipit-source-id: 0c7a01f33fde35dbc8004c5bb6e5b22f8f0ea369
  • Loading branch information...
hovox authored and facebook-github-bot committed Jan 29, 2018
1 parent be7037f commit 2fef1bafc8bee33432486212caf4fef5c659dd37
@@ -65,7 +65,7 @@ process() {
cd "$ROOT/third-party-podspecs"
push Folly.podspec
push DoubleConversion.podspec
push GLog.podspec
push glog.podspec
process "$ROOT/ReactCommon/yoga"
process "$ROOT" _ignore_me_subspec_for_linting_
@@ -10,7 +10,7 @@ do |spec|
spec.module_name = 'folly'
spec.dependency 'boost-for-react-native'
spec.dependency 'DoubleConversion'
spec.dependency 'GLog'
spec.dependency 'glog'
spec.source_files = 'folly/Bits.cpp',
@@ -1,5 +1,5 @@ do |spec| = 'GLog' = 'glog'
spec.version = '0.3.4'
spec.license = { :type => 'Google', :file => 'COPYING' }
spec.homepage = ''

0 comments on commit 2fef1ba

Please sign in to comment.