Permalink
Browse files

BREAKING: Removed couple unused notifications from RCTUIManager

Reviewed By: javache

Differential Revision: D5477733

fbshipit-source-id: 85f90c534fffd6ea9f8f7ad1c0e0fddc1ebdec62
  • Loading branch information...
shergin authored and facebook-github-bot committed Jul 24, 2017
1 parent 1b9b366 commit 324eba14d5815883bf46943ccfcdea0c851bb0c1
Showing with 0 additions and 28 deletions.
  1. +0 −17 React/Modules/RCTUIManager.h
  2. +0 −11 React/Modules/RCTUIManager.m
@@ -42,23 +42,6 @@ RCT_EXTERN BOOL RCTIsUIManagerQueue(void);
*/
RCT_EXTERN NSString *const RCTUIManagerWillUpdateViewsDueToContentSizeMultiplierChangeNotification;
/**
* Posted whenever a new root view is registered with RCTUIManager. The userInfo property
* will contain a RCTUIManagerRootViewKey with the registered root view.
*/
RCT_EXTERN NSString *const RCTUIManagerDidRegisterRootViewNotification;
/**
* Posted whenever a root view is removed from the RCTUIManager. The userInfo property
* will contain a RCTUIManagerRootViewKey with the removed root view.
*/
RCT_EXTERN NSString *const RCTUIManagerDidRemoveRootViewNotification;
/**
* Key for the root view property in the above notifications
*/
RCT_EXTERN NSString *const RCTUIManagerRootViewKey;
@class RCTLayoutAnimationGroup;
@class RCTUIManagerObserverCoordinator;
@@ -54,9 +54,6 @@ static void RCTTraverseViewNodes(id<RCTComponent> view, void (^block)(id<RCTComp
char *const RCTUIManagerQueueName = "com.facebook.react.ShadowQueue";
NSString *const RCTUIManagerWillUpdateViewsDueToContentSizeMultiplierChangeNotification = @"RCTUIManagerWillUpdateViewsDueToContentSizeMultiplierChangeNotification";
NSString *const RCTUIManagerDidRegisterRootViewNotification = @"RCTUIManagerDidRegisterRootViewNotification";
NSString *const RCTUIManagerDidRemoveRootViewNotification = @"RCTUIManagerDidRemoveRootViewNotification";
NSString *const RCTUIManagerRootViewKey = @"RCTUIManagerRootViewKey";
@implementation RCTUIManager
{
@@ -237,10 +234,6 @@ - (void)registerRootView:(RCTRootContentView *)rootView
self->_shadowViewRegistry[shadowView.reactTag] = shadowView;
[self->_rootViewTags addObject:reactTag];
});
[[NSNotificationCenter defaultCenter] postNotificationName:RCTUIManagerDidRegisterRootViewNotification
object:self
userInfo:@{RCTUIManagerRootViewKey: rootView}];
}
- (NSString *)viewNameForReactTag:(NSNumber *)reactTag
@@ -746,10 +739,6 @@ - (void)_removeChildren:(NSArray<UIView *> *)children
[uiManager _purgeChildren:(NSArray<id<RCTComponent>> *)rootView.reactSubviews
fromRegistry:(NSMutableDictionary<NSNumber *, id<RCTComponent>> *)viewRegistry];
[(NSMutableDictionary *)viewRegistry removeObjectForKey:rootReactTag];
[[NSNotificationCenter defaultCenter] postNotificationName:RCTUIManagerDidRemoveRootViewNotification
object:uiManager
userInfo:@{RCTUIManagerRootViewKey: rootView}];
}];
}

0 comments on commit 324eba1

Please sign in to comment.