Permalink
Browse files

React Native: disable multipart bundle transmission for now

Reviewed By: davidaurelio

Differential Revision: D5329011

fbshipit-source-id: 5093bc5b1858314512313934fba04f4343fe0d5b
  • Loading branch information...
jeanlauliac authored and facebook-github-bot committed Jun 29, 2017
1 parent d666f30 commit 33057aacbf5ff6cd4d0e44eeddf9c328574883b4
@@ -51,7 +51,10 @@ public void downloadBundleFromURL(
final String bundleURL) {
final Request request = new Request.Builder()
.url(bundleURL)
.addHeader("Accept", "multipart/mixed")
// FIXME: there is a bug that makes MultipartStreamReader to never find the end of the
// multipart message. This temporarily disables the multipart mode to work around it, but
// it means there is no progress bar displayed in the React Native overlay anymore.
//.addHeader("Accept", "multipart/mixed")
.build();
mDownloadBundleFromURLCall = Assertions.assertNotNull(mClient.newCall(request));
mDownloadBundleFromURLCall.enqueue(new Callback() {

2 comments on commit 33057aa

@janicduplessis

This comment has been minimized.

Show comment
Hide comment
@janicduplessis

janicduplessis Jul 13, 2017

Collaborator

@jeanlauliac Do you have a repro so I can try fixing this?

Collaborator

janicduplessis replied Jul 13, 2017

@jeanlauliac Do you have a repro so I can try fixing this?

@jeanlauliac

This comment has been minimized.

Show comment
Hide comment
@jeanlauliac

jeanlauliac Jul 14, 2017

Contributor

I'm afraid I don't have a minimal repro. We can repro on our internal Android package and have a task to track this. I'll see if I can create a minimal repro.

Contributor

jeanlauliac replied Jul 14, 2017

I'm afraid I don't have a minimal repro. We can repro on our internal Android package and have a task to track this. I'll see if I can create a minimal repro.

Please sign in to comment.