Please sign in to comment.
Changed prop name "currentViewStates" to "accessibilityStates" in And…
…roid (2/3) Summary: Context: After discussing with @[1038750002:yungsters], `currentViewStates` is a very ambiguous name for a prop, especially because there are only two possible values. From a developer's perspective, it makes more sense to just call them `accessibilityStates` because the main use for them is to add states to Talkback and Voiceover. Defense for changing name in Android: The actual implementation of what we're changing under the hood in Native Code is abstracted away from developers using React Native, so as long as behavior is as they would expect, it makes more sense to change the name into a clear one regardless of how it is implemented. Changes: changed the Prop name from `currentViewStates` to `accessibilityStates` in the BaseViewManager file where the view property is being exposed. Reviewed By: PeteTheHeat Differential Revision: D8896389 fbshipit-source-id: 35dcd9239fae016b790e528947994681684bd654
- Loading branch information...
Showing with 5 additions and 5 deletions.