Please sign in to comment.
RN TextInput: don't let user more than maxLength when TextInput alrea…
…dy exceeds it Summary: We had a classic integer underflow problem here. Before we would let you type endlessly when the text already exceeded the TextInput maxLength, now we only let you erase characters. There is still a small problem with the TextInput: how do you handle when the value (set from JS) exceeds the maxLength? This could happen pragmatically, just by passing in a very large value or when changing maxLength (e.g. when changing from 4 to 3 digits in the case of a AMEX security code -> VISA security code). Me and achen1 discussed firing onChange in these cases and truncating the number manually (to ensure JS's data model) was aware of the change but it seemed fraught with bugs and general weirdness in what the caller would expect to happen. Reviewed By: javache Differential Revision: D3991210 fbshipit-source-id: dc401c4a7aefe09fa749cd1168d36343d39dc196
- Loading branch information...
Showing with 38 additions and 2 deletions.