Please sign in to comment.
Disable onKeyPress logic when handler not defined
Summary: <!-- Required: Write your motivation here. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. --> There are some bugs surrounding the use of unicode characters that are causing issues with `onKeyPress` on Android: see #18405 (comment). We disable the creation and use of `ReactEditTextInputConnectionWrapper` unless the onKeyPress prop is specified, so that this code is 'opt-in' & not a general regression for every use of the TextInput. N.B. it seems to introduce a lot of unnecessary code complexity to allow for enabling/disabling the onKeyPress events after a InputConnection has been created in `onCreateInputConnection` when the keyboard focusses (a new input connection is created whenever a TextInput gains focus) so I opted not to for simplicity's sake. Build & debug RNTest app, verify ReactEditTextInputConnectionWrapper code not executed if onKeyPress function not specified. <!-- Required: Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! --> [ANDROID] [BUGFIX] [TextInput] - Disable TextInput onKeyPress event from being fired unless callback specified. Closes #18443 Differential Revision: D8149625 Pulled By: hramos fbshipit-source-id: cdf28141d71cdedd67a6ef350e3a3b955f97e340
- Loading branch information...
Showing with 11 additions and 1 deletion.