Permalink
Browse files

Do not use Node 8.x specific Stream.final

Summary:
grabbou: "This has been recently added to Node 8.x. Since it makes our tests to fail, I decided to
do a workaround that works for all the versions."

Originally patched in `0.52-stable` by grabbou

Fixes Node 6 JavaScript tests.
Closes #17298

Differential Revision: D6616521

Pulled By: hramos

fbshipit-source-id: 7256450d824a60a14006af7a68191222b3a5041a
  • Loading branch information...
hramos authored and facebook-github-bot committed Dec 21, 2017
1 parent a0ff8c7 commit 4216cdef13c9ed47b9c746b39a0ddfdaf846d495
Showing with 0 additions and 3 deletions.
  1. +0 −3 local-cli/__mocks__/fs.js
@@ -347,9 +347,6 @@ fs.createWriteStream.mockImplementation(filePath => {
const writeStream = new stream.Writable({
write(chunk, encoding, callback) {
this.__chunks.push(chunk);
callback();
},
final(callback) {
node[path.basename(filePath)] = this.__chunks.join('');
callback();
},

0 comments on commit 4216cde

Please sign in to comment.