Permalink
Browse files

packager: GlobalTransformCache: reduce asynchronicity for non-cached …

…bundles

Reviewed By: davidaurelio

Differential Revision: D4745595

fbshipit-source-id: 3126fdcc11dd1c8085316457ead0cabae633d0db
  • Loading branch information...
jeanlauliac authored and facebook-github-bot committed Mar 21, 2017
1 parent 4cbb645 commit 439cb76a005fbffd23be6c5b6a61c7806f1b716d
Showing with 5 additions and 4 deletions.
  1. +4 −3 packager/src/lib/GlobalTransformCache.js
  2. +1 −1 packager/src/node-haste/Module.js
@@ -247,14 +247,15 @@ class GlobalTransformCache {
});
}
shouldFetch(props: FetchProps): boolean {
return this._profileSet.has(props.transformOptions);
}
/**
* This may return `null` if either the cache doesn't have a value for that
* key yet, or an error happened, processed separately.
*/
async fetch(props: FetchProps): Promise<?CachedResult> {
if (!this._profileSet.has(props.transformOptions)) {
return null;
}
const uri = await this._fetcher.fetch(GlobalTransformCache.keyOf(props));
if (uri == null) {
return null;
@@ -303,7 +303,7 @@ class Module {
callback: (error: ?Error, result: ?TransformedCode) => void,
) {
const {_globalCache} = this;
if (_globalCache == null) {
if (_globalCache == null || !_globalCache.shouldFetch(cacheProps)) {
this._transformCodeForCallback(cacheProps, callback);
return;
}

0 comments on commit 439cb76

Please sign in to comment.