From 46bc85478f424ec7cd89fe4559b679edcefe317d Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Fri, 23 Sep 2022 11:20:07 +0100 Subject: [PATCH] fix: remove duplicated vars --- sdks/hermes-engine/hermes-engine.podspec | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/sdks/hermes-engine/hermes-engine.podspec b/sdks/hermes-engine/hermes-engine.podspec index 57e853172af941..4b6b65b0e52a61 100644 --- a/sdks/hermes-engine/hermes-engine.podspec +++ b/sdks/hermes-engine/hermes-engine.podspec @@ -21,9 +21,6 @@ version = package['version'] hermestag_file = File.join(react_native_path, "sdks", ".hermesversion") isInCI = ENV['CI'] == true - -ENV['REACT_NATIVE_PATH'] = react_native_path - # sdks/hermesc/osx-bin/ImportHermesc.cmake import_hermesc_file=File.join(react_native_path, "sdks", "hermesc", "osx-bin", "ImportHermesc.cmake") @@ -71,26 +68,27 @@ Pod::Spec.new do |spec| } if source[:git] then + hermes_utils_path = "#{react_native_path}/sdks/hermes-engine/utils" spec.prepare_command = <<-EOS # When true, debug build will be used. # See `build-apple-framework.sh` for details - + export RELEASE_VERSION="#{version}" export IOS_DEPLOYMENT_TARGET="#{spec.deployment_target('ios')}" export MAC_DEPLOYMENT_TARGET="#{spec.deployment_target('osx')}" - BUILD_TYPE=#{HermesHelper::BUILD_TYPE == :debug ? "Debug" : "Release"} + export BUILD_TYPE=#{HermesHelper::BUILD_TYPE == :debug ? "Debug" : "Release"} # Set HERMES_OVERRIDE_HERMESC_PATH if pre-built HermesC is available #{File.exist?(import_hermesc_file) ? "export HERMES_OVERRIDE_HERMESC_PATH=#{import_hermesc_file}" : ""} #{File.exist?(import_hermesc_file) ? "echo \"Overriding HermesC path...\"" : ""} # Build iOS framework - $REACT_NATIVE_PATH/sdks/hermes-engine/utils/build-ios-framework.sh + #{hermes_utils_path}/build-ios-framework.sh # Build Mac framework - $REACT_NATIVE_PATH/sdks/hermes-engine/utils/build-mac-framework.sh + #{hermes_utils_path}/build-mac-framework.sh EOS end end