Permalink
Browse files

Issue #16159 - RCTImageStoreManager's priority

Summary:
RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities.

Issue: #16159
Closes #16160

Differential Revision: D6017931

Pulled By: shergin

fbshipit-source-id: 91f2737af4f2f97197734b696105e1cdc5683365
  • Loading branch information...
tsjamm authored and facebook-github-bot committed Oct 10, 2017
1 parent dbe6044 commit 4e5d50d6ad6348530640593ea67a47c45ed193b2
Showing with 6 additions and 1 deletion.
  1. +1 −1 Libraries/Image/RCTImageLoader.m
  2. +5 −0 Libraries/Image/RCTImageStoreManager.m
@@ -66,7 +66,7 @@ - (void)setUp
- (float)handlerPriority
{
return 1;
return 2;
}
- (id<RCTImageCache>)imageCache
@@ -32,6 +32,11 @@ @implementation RCTImageStoreManager
RCT_EXPORT_MODULE()
- (float)handlerPriority
{
return 1;
}
- (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)())block
{
dispatch_async(_methodQueue, ^{

0 comments on commit 4e5d50d

Please sign in to comment.