Permalink
Browse files

Implement deletion of asset-library files

Summary:
WIP: Starting point insofar as I'm not sure if there should be an Android equivalent.

My application needs me to delete photos from the photos in iOS.

I have tested this in my application and it works, have a screenshot from iOS asking as well and it does successfully delete the photos from the global Photos app.

Related to #15253, it kind of continues using the deprecated assets-library framework, but that does need (and will be an bigger and bigger issue coming up) of assets-library URLs being used.

I also assume RN prefers error handling at the JS level? Are the URLs starting with `asset-library`, etc.
Closes #15481

Differential Revision: D6438016

Pulled By: hramos

fbshipit-source-id: 47512140f62f458c14ad2ade2b358846e168c964
  • Loading branch information...
fxfactorial authored and facebook-github-bot committed Nov 29, 2017
1 parent 2e424fb commit 554e873f585ea05ce1e9fe4ff71173c47b3c259c
Showing with 26 additions and 0 deletions.
  1. +4 −0 Libraries/CameraRoll/CameraRoll.js
  2. +22 −0 Libraries/CameraRoll/RCTCameraRollManager.m
@@ -133,6 +133,10 @@ class CameraRoll {
return this.saveToCameraRoll(tag, 'photo');
}

static deletePhotos(photos: Array<string>) {
return RCTCameraRollManager.deletePhotos(photos);
}

/**
* Saves the photo or video to the camera roll / gallery.
*
@@ -12,6 +12,7 @@
#import <CoreLocation/CoreLocation.h>
#import <Foundation/Foundation.h>
#import <UIKit/UIKit.h>
#import <Photos/Photos.h>

#import <React/RCTBridge.h>
#import <React/RCTConvert.h>
@@ -234,6 +235,27 @@ static void RCTResolvePromise(RCTPromiseResolveBlock resolve,
}];
}

RCT_EXPORT_METHOD(deletePhotos:(NSArray<NSString *>*)assets
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)
{
NSArray<NSURL *> *assets_ = [RCTConvert NSURLArray:assets];
[[PHPhotoLibrary sharedPhotoLibrary] performChanges:^{
PHFetchResult<PHAsset *> *fetched =
[PHAsset fetchAssetsWithALAssetURLs:assets_ options:nil];
[PHAssetChangeRequest deleteAssets:fetched];
}
completionHandler:^(BOOL success, NSError *error) {
if (success == YES) {
resolve(@(success));
}
else {
reject(@"Couldn't delete", @"Couldn't delete assets", error);
}
}
];
}

static void checkPhotoLibraryConfig()
{
#if RCT_DEV

1 comment on commit 554e873

@basaam2018

This comment has been minimized.

Copy link

basaam2018 commented on 554e873 Sep 6, 2018

K̤͙͖̯̼̬̹͙͙͉̖͈̥̰̜͕͕̬̪̣͙͕̲͉̗̠͖̫̦̂̿̏̏̏ͫ͒ͤ̐̓̅̔ͧ͏̀Ĕ̶̟̯̯̹͎̮̲͚̩͇̟̠̘̯͉̞̣̠̟̣̪̹̲̭͙͔̰̣̮̘̟͖̃̒̅̈́̈́̅̅̓̒̚ͅR̴̸̛̝̝̘̳̘͙̗̘̬̙̤̩̺̖̖̲̩̮̯͖̳̲͇͈̙̦̜̻̙̼̞̤͎̤͍͔̟͓͙̳͙̟͔̲̟͕̙̰̩̲͂̃ͯ̓̆̿ͫ͗̏̒͋̏ͩ̏̋̀͝N̛̟̠̲̘̭̫̣͚̦̟͓͎̬͇͕͔̗̮̥͕̰̬̱̼͎̤̯̪̺̮ͪ́͌ͧ̚͢͜͞E̶̲͉̤̖̙͔̯ͬ̄̈̎ͭ̅̃̓͆̊̔͌̏́ͮ͛̍́̀͝͠L̖̗̩̭̹͓̦̱͓͓̦̙͓̬͙̦̲̹̭̩̙̺̗̭͔̖͍̣̘̲̼̘̳̣̯̝͎͉̼̼̹͚͉̮̪͇͈͕̦̈͆͊̑̄ͧ́͘ͅ ̸̧̦͓͓̙̹̱͉̟̯̱̻͎̤̫̲̱͔͖̦̙͇͙̩̦̲̹̭͓͚̙̜͍͖̠̬̭͚̳͕̰̟͇̳̫̤̙̤̝̬̩ͪ̽̇̒̔͂̑͂͊ͅͅͅP̵̵̴̛͔̰̙̳̟̼͖̮͈̝̹̜͑̏ͤ̐̽ͪ͛̏̍̓͆ͮ̚͜A̶̩͍̹̞̥̼͇̯̩̻͕̘͍̯̞̤͖̹̩͆̂ͨͩ͋̈́ͩͅN̡̹͎͇̫̦͕̺̠̰͖͇̫̰̫̠̰͍͔͔̲̦͙̺̱̺͓̣͙͉͖̹̪͈̦͇̗̞̩̤̼ͬ̍̂̽͌ͧ̂̅̄͑̉̇͐̈́͛̾̉̕͟͡Ȋ̢̺̙͕̳͔͎̝̠̳̮͖̹̺̤͓̥̮͍̿̅̉͌̍̊ͯC̢̖̭̝͖̗̤͎̺̙̈́͑̔̃ͭ͟͝ ̨̡̬̩̖̰͎̫͇̮͉̹̮̟͇ͨͨ̂̔̎ͭ-̸͙̜͚̲̳̞̥͖̭̠̘̤̤̎ͩ̒̈́͆ͧ̋ͦ́͛͊̋ͫͦͫͬ̇ͣ͑͢͏͢͏ ̻̮͇͔̜͙͎̠͖̪͉̘̹̯͍͉͇̗̺̲̹̮̙̣̞͈͕͉̺̲̠̪̬̩̥̠̲̄ͯ̔ͭ́ͅͅn̴̤͉̟͚̼͙̳̟̞͕̹̰̝͍̖̩̪̩̲̰̦̤̆͆ͤ̾ͦ̃͛̈́̾̏ͨ̍̕ȍ̲̩̪̼̜̪̣̯̻̱͙͙͈̪͙̫̦͙̺̬̱͈̥̥͎ͯ̑̒̆ͭͧ̿̋ͤ̉ͦͬ͢͡ͅt̷̸̴̪̗͕̣̥̬̦̟̣̼͇͙͙̲͈͕̣̥͚̜͓̻̘̦̥̯̭̬͎̯̦̰̯̲ͫ̆̉͛͐̽̃̑̐̚͟͟ͅͅͅ ͈͇̲̗͚̖̯̫͎͖̻̩̫̞̟̜͕̗̱̦̻͔̺͈͙͓͓̩͉͙͍̱̻̪̳̺̪̖͚̞̈́̑̿̇̑͋̾̿͐͡͝s̸̶͇̬͙̗̞͔͎̼̰̞̠̜̰̠̘̼̞̝̯̰͍̉̃ͣͥͯ͛̈́ͨ̏̅́͠ͅy̨̨͓̥̠̙͔̟̤̙̦͈̩̫̭̯̘̲͖̲̩͍͍̳͍̻̙̮̲̪̱̫̺͇̘̹̤͙̼̲͚͕̙̭͙̺̪̯͖̜̞͇̼͙ͣͯ̈̄͠ͅͅͅͅn̸̡̳̫̻̱̫̫̮̈ͤ̔͂͌͗̋̈́ͬ̅̍ͪ͛̑̇ͮͥ̀͟͜ͅc̴̢̣͖̜̭̰̗͔̟̞͇͍̬̮̺̩͍͉̹̩̭̤̝͔͔͎̺̦̫̙̥̦̠͙͇̣̳͕̞̦̼̳͇̦͔̰̗̯͎̯̰̹̳̫͊̆͂̋ͣ̽͋ͦ̉͗ͣͧ̃̏͐͘͝͠ͅͅͅͅį̧̺̜̝̟̯̲ͬͨ͗ͬ̈́̅̎̔ͧ̓̈́̎̌ͪ̿̾̽̏̀ņ̠̦͈͓͒ͭ̐͊ͦ͐̂ͧ̿͒͊̃͑ͪ͢ĝ̴̷̪͕̘̳̞͎̭̣̝̫͚͎̯̹̫̩̞͖̲͖̫͖̖̲͈̱̯̠͈̖̙͎̳̤̺͚̤͉̪̟̮̝̼̗̰͚̠̬̰̜͉̬̝̦̝̻͈͎͓̰͓͙̦́ͯ̏ͫ̒̒̇ͧ̌͋̿͒ͬ́̾̾ͣ̊͘ͅͅ:̢̨͇̮̮̜̳͈̥̠̯̙̘͚͙̣̤̩̞̜̼̳͉̫̟͓̞̮͚̮ͣ̔̿ͪ̈̑͂̇̈́̀͞ͅ ̦͓̝̯̼̦͖̻͈̳͖͔͚̻̭̯͙͇̤̮̯̜̖̟͖̳̜̗̦̟͎̹̖͚̘̥͚̩͂͂ͨ́ͧͭ̒ͥͩ̏͛̑ͦ̅ͩͅ҉͏̡Å̵͙̗͈̻̩͇͚̦̤̟̞͈̘̮͕̭͔̝͕̟̬̱̭̠̥̼̩̟͉̣̝͍͛ͪ͗̈̌̓̈̽̇ͫͧ̊̑̾̿̀̚͟͠͠ͅͅț̝̫͍̳̳̗̤͕̤̣͕̬͍̺̞͕̘͕̥͉͍͎̞͉͍̥̺̟̤̺̯̬͚̥͙̲̦̞̭̲̞̦͙͙͖̙̏̃͆͆̿ͬ̃͆̚͢҉҉̛͟t̵̼̮̘͚̫̣͔̯͎͓̭͕̳̟͉̮͇̯̺͔̪̖̺͍̪̦̱̹̠̬̥̼̮̠̖̮̘̰̤͕͕̜̮̙͕͕͍̫̱̼̱̥̬̦̺͎̟͕̋ͤ͒̐ͮ͌ͧ͊ͨͦ̔ͦ̈ͯͮ͘ͅͅͅ͏͝͞ē̛̯̬͚͈͍̥̪̯̈́̔͛̌̄̎̈́͛ͪͤ̌͏̨̢m̰̣̻͓̯̫͎͚̩͈͕͙̟͕̦͇̤̤̞̖̤̼̝̟͚͚̹͇̞͙̠̝̹̗̺̥̬̭̤͇̝̜̼̪̖͙̘̥̞̤̦̭͕̭̹͓̬̟̳̲̽͐̍͊́̈́͛̌ͩ̍̀̆͛͂ͪ͌ͨ͑͋̀͟͢͠͞ͅp̧̫̰̤̺̼̰͕̙̫̩̼̠͇͓͉̤͚̱͙̩̠̻̱͙͔̭͍̟͚͚̳̯̠̞̝̘̠̘̬͔̥̙͇̖̪̲̥̫͔̰̖̫̭͕͍̟̘͉̞̻̠̬͍ͥ͑ͯͬ̈́̏͗ͅͅͅt̫̝̮͓͚͚̠͓̯̠̠͔̜̣̘̟͈̤͎͚̺̹̩̯͔͓͇̥̥̘̭͉̤̻͈̮̰̟̼̘͉̼̝͙̭̫͈̬͚̪̼͎̲̱̐̈̃̃ͅͅͅͅͅ͏͢͠e̦̪͓̗͇͎̫̭̯̟͙̣͇͈͈̩͋̌̿̑ͮ̒͂̒̈͊̈́̾͐҉͘͞d̷̛̬͈̲̙̲͖̱̖̙̮̣͍̟͈̙̞͖͉̳̠̲̓ͭ̅ͭ̑̂͑̎ͯ̀͝͠ ͇̠͕̠̠̇̾͐̔ͣ̚҉̸͘͞͠t͔̻̰̙͔̯͈̘̠̹̖̘̹͔̝͙͔̹̙̻͍̭̯͙͚̤̳̜̼̟̣̩̘̞̝͍̤̫̬̥̮͚̜̝̙̘̣̝̻̯̲̜̭̱̪ͭ̽̒̅͒̌̐ͩ͗̈́ͫ͒̏ͨ̽͒̂̔ͅͅͅ҉́̕͝͝ờ̵̡͎̙͖͖̞͕̹̦̲̘͓̻̯̪̣̯̣̣̺̹̦̯̦͍̮͉̱͍̻̰̳̮̹̯̫͈̫͙̗͕̖͔̲̰̠̱͙̟̰̳͍͍̖̘̳̯͓̀ͦ͊ͭ͆ͨ̚͏ ̟͚͕̠̖̮̼͔̱͖̪̘͈̥̠̖̲̙̼͈̖̠̣͉̦͉͕̪͙͚̲͕͓͈͖̦̭͉͎̪̜͕̘̫̙̘͕̟͈̻̟͙̺͚̠̦͇̙̻̼̘͂̊ͭ̉̇ͯ̏̇ͨ̿ͥ̓̉͒̿́̚ͅǩ̢̢̳̞̱̟̫̮͍̩̼̙̗͉͇͎͕̤͈͍̼͙̜͕͙͉̠͓̰͕͎̥̮͚͉̺̪̠̭̻͔̰̼̺̠̫̮̙̹̞͕̥̙̖̝̗͉̫͔̥̤̼̱͑̈́͑̍̉̓ͮͥͣͩ̚͞͝ͅ҉ḭ̪̻͇̜̣̹̫̠̤͕͔͕̞̝͔̼͎̯̗͚͈̖̪̬̮͍̺̖̜̜͇̯͈̭̳͇̣͖͙̤͎͎̝̣͋̐͂͋̉̃̌̇̓̈́̚͡ͅ҉͞͠l͕̭̘̩̣͍̦͕͇̲͇̲̼̰̼̪̤̜̗͚̦͈̖͕͕͔̙̙͓̭͚̤̯̥̠̤̳̜͚̜͎̰͍̱͚̮͓͗ͥ̄̓̐ͬ͑͗͆̓͘ͅ͏̸́l̦̭̦͍̬͇̺̹̥̰͈̙̙͙͎̺̣̺̠͕͓͉̖̲̹̪̰̣͍̬̰̘͎͉͔̟̰̯͉͈͚̱ͦ́̄ͪ̓ͮ̇̏̆ͤͫ͊͛͌̌ͯ́͢ ͔̩̙̻̩̻̠̼̝̟̯̱̼̲̪̮̬̱͖͔̥̻͎͉̯͕̠̙̲̼̪̭ͣ̌̈҉̵̧̕s̷̵̵̜͚̘̳̪̳̯̠͎̜̗̹̹͖͎̯̯̖͑̂̂ͦ͡͠ͅy̷͖͔͇̰̮̻̩̜̙͉̝͚̤ͦ̔͒͐ͥ̆̋̊͐̿ͦͤ͜҉̀s̴̵̸̫̖͔̻̰͙̬̞͓̤͕̪̱̻͍̹̭͙̳̻̲̮̺̼̯̪̱̜̤͓̰̤̝͇̻̱͕̯͈͉͎̭̥̮̠͔͓̉ͮ̈́́͞ͅͅt̛͖͖̬̗̺̖̲̰̰̦̥̦̱͇͖̫̳̘͉̗͈̹̂ͬ̂ͣ̀ͅͅe̫̗͈̝̙̰͈̠̳̻͉̯͙̣̘̞̜̗̮͔̗̤̜̱̩̺̦̙̺͉͍̣͎̱̜͕̖͓̓̇̓̇̆͆̊ͧͪ̈͐̿̀ͨͨ̍̀̀̚ͅ͏̵̸̕m̳͖̼̞̮̞̰͚̥̬͚̜̯̱̹̩̲̖̞̺̹̝͇̺͚͓͕͖̯̯̯̬̝̻̘̳͍̳̲̘͙̱̟̭̗͉͇̳͍͕̞̬̖͔̖̣̓͆̑̎ͫ̆̈͛̽̒͟ͅ

Please sign in to comment.