Skip to content
Permalink
Browse files

SYSTEM_ALERT_WINDOW only in debug builds (#23504)

Summary:
SYSTEM_ALERT_WINDOW permission is used only for debug builds to show draw overlay views or show warnings/errors. This permissions is unused in release builds, and there is an issue regarding removing unused permissions on Android build #5886 (comment). This PR removes SYSTEM_ALERT_WINDOW from all builds bug debug.

[Android] [Changed] - SYSTEM_ALERT_WINDOW permissions available only in debug builds
Pull Request resolved: #23504

Differential Revision: D14123045

Pulled By: cpojer

fbshipit-source-id: 68829a774ff23c7cb2721076a9d3870405f48fea
  • Loading branch information...
dulmandakh authored and grabbou committed Feb 18, 2019
1 parent dff3f60 commit 56fc630368021c05b96a09733737d31a847ae7fe
@@ -1,7 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.facebook.react">

<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

<application />

</manifest>
@@ -1,5 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

<application tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" android:networkSecurityConfig="@xml/react_native_config" />
</manifest>
@@ -2,7 +2,6 @@
package="com.helloworld">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

<application
android:name=".MainApplication"

0 comments on commit 56fc630

Please sign in to comment.
You can’t perform that action at this time.