Permalink
Browse files

Added ReactNative feature-flag switch between Stack and Fiber builds

Reviewed By: sebmarkbage

Differential Revision: D4606164

fbshipit-source-id: 5f25dbc52298d359e11e52341ff3570c797a6ea9
  • Loading branch information...
bvaughn authored and facebook-github-bot committed Mar 17, 2017
1 parent 17cb70e commit 6620b1ff7db9e9cf906a2bcee3184a35c350f95b
Showing with 5 additions and 2 deletions.
  1. +5 −2 Libraries/Renderer/src/renderers/native/ReactNative.js
@@ -11,5 +11,8 @@
*/
'use strict';
// TODO (bvaughn) Enable Fiber experiement via ReactNativeFeatureFlags
module.exports = require('ReactNativeStack');
const ReactNativeFeatureFlags = require('ReactNativeFeatureFlags');
module.exports = ReactNativeFeatureFlags.useFiber
? require('ReactNativeFiber')
: require('ReactNativeStack')

4 comments on commit 6620b1f

@sunnylqm

This comment has been minimized.

Show comment
Hide comment
@sunnylqm

sunnylqm Mar 17, 2017

Contributor

Can somebody explain the main advantages of switching to fiber on RN? Thanks!

Contributor

sunnylqm replied Mar 17, 2017

Can somebody explain the main advantages of switching to fiber on RN? Thanks!

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset May 1, 2017

Collaborator

I agree, an example about it would be great.

Collaborator

kelset replied May 1, 2017

I agree, an example about it would be great.

@soorajvnair

This comment has been minimized.

Show comment
Hide comment
@soorajvnair

soorajvnair May 2, 2017

As per my understanding, to enable fiber, you'll need to go into /node_modules/reactnative/Libraries/Renderer/src/renderers/native/ReactNativeFeatureFlags.js and then change the useFiber flag to true.
screen shot 2017-05-02 at 8 10 44 am

As per my understanding, to enable fiber, you'll need to go into /node_modules/reactnative/Libraries/Renderer/src/renderers/native/ReactNativeFeatureFlags.js and then change the useFiber flag to true.
screen shot 2017-05-02 at 8 10 44 am

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset May 2, 2017

Collaborator

@soorajvnair have you tested it? Is the performance difference "perceivable"?

Collaborator

kelset replied May 2, 2017

@soorajvnair have you tested it? Is the performance difference "perceivable"?

Please sign in to comment.