Skip to content

Commit 7a794cc

Browse files
tadeuzagallofacebook-github-bot-7
authored andcommitted
Strip dev only modules
Summary: public Make sure some modules that are only available in dev mode are only included in dev bundles. Depends on: D2663838 Reviewed By: davidaurelio Differential Revision: D2663889 fb-gh-sync-id: 42be40b865ef305828b3519556125af090ec61f4
1 parent 9e670a6 commit 7a794cc

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,11 @@ function setUpNumber() {
180180

181181
function setUpDevTools() {
182182
// not when debugging in chrome
183-
if (__DEV__ && !window.document && require('Platform').OS === 'ios') {
184-
var setupDevtools = require('setupDevtools');
185-
setupDevtools();
183+
if (__DEV__) { // TODO(9123099) Strip `__DEV__ &&`
184+
if (!window.document && require('Platform').OS === 'ios') {
185+
var setupDevtools = require('setupDevtools');
186+
setupDevtools();
187+
}
186188
}
187189
}
188190

@@ -202,6 +204,8 @@ setUpDevTools();
202204

203205
// Just to make sure the JS gets packaged up. Wait until the JS environment has
204206
// been initialized before requiring them.
205-
require('RCTDebugComponentOwnership');
207+
if (__DEV__) {
208+
require('RCTDebugComponentOwnership');
209+
}
206210
require('RCTDeviceEventEmitter');
207211
require('PerformanceLogger');

Libraries/ReactIOS/renderApplication.ios.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@
1010
*/
1111
'use strict';
1212

13-
var Inspector = require('Inspector');
1413
var RCTDeviceEventEmitter = require('RCTDeviceEventEmitter');
1514
var React = require('React');
1615
var StyleSheet = require('StyleSheet');
1716
var Subscribable = require('Subscribable');
1817
var View = require('View');
19-
var WarningBox = require('WarningBox');
2018

2119
var invariant = require('invariant');
2220

21+
var Inspector = __DEV__ ? require('Inspector') : null;
22+
var WarningBox = __DEV__ ? require('WarningBox') : null;
23+
2324
var AppContainer = React.createClass({
2425
mixins: [Subscribable.Mixin],
2526

@@ -28,7 +29,7 @@ var AppContainer = React.createClass({
2829
},
2930

3031
toggleElementInspector: function() {
31-
var inspector = this.state.inspector
32+
var inspector = !__DEV__ || this.state.inspector
3233
? null
3334
: <Inspector
3435
rootTag={this.props.rootTag}

0 commit comments

Comments
 (0)