Skip to content
Permalink
Browse files
Bring back JS bundle loading progress bar on Android
Summary: The progress bar on Android was disabled in D5329011 because of T19653381, but was never enabled again. I spent some time trying to reproduce the issue of the bundle being stuck while loading, but didn't succeed. So let's enable the progress bar and monitor whether people would start seeing this bug again.

Reviewed By: cpojer

Differential Revision: D17148134

fbshipit-source-id: 5130b809460bc743d26a6e88961f81061089fe1d
  • Loading branch information
makovkastar authored and facebook-github-bot committed Sep 2, 2019
1 parent d8d3ed5 commit 7b9d6d19e2c0854aa53587ef68ce715fb7803e2a
Showing 1 changed file with 1 addition and 5 deletions.
@@ -109,11 +109,7 @@ public void downloadBundleFromURL(
final Request request =
requestBuilder
.url(formatBundleUrl(bundleURL))
// FIXME: there is a bug that makes MultipartStreamReader to never find the end of the
// multipart message. This temporarily disables the multipart mode to work around it,
// but
// it means there is no progress bar displayed in the React Native overlay anymore.
// .addHeader("Accept", "multipart/mixed")
.addHeader("Accept", "multipart/mixed")
.build();
mDownloadBundleFromURLCall = Assertions.assertNotNull(mClient.newCall(request));
mDownloadBundleFromURLCall.enqueue(

0 comments on commit 7b9d6d1

Please sign in to comment.