Permalink
Browse files

Loosen Platform check to allow better code sharing for out-of-tree pl…

…atforms

Summary:
Don't lock out other non-iOS platforms (e.g. Windows) with an overly
specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking.

Tested Android and iOS playground on simulators.

 [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms.
Closes #18308

Differential Revision: D7230803

Pulled By: hramos

fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
  • Loading branch information...
Matt Hargett authored and facebook-github-bot committed Mar 12, 2018
1 parent 19dd9a2 commit 84affbd6a371dd865a3550b1fde1ebabee921341
Showing with 1 addition and 1 deletion.
  1. +1 −1 Libraries/ReactNative/UIManager.js
@@ -77,7 +77,7 @@ if (Platform.OS === 'ios') {
});
}
});
} else if (Platform.OS === 'android' && UIManager.ViewManagerNames) {
} else if (UIManager.ViewManagerNames) {
UIManager.ViewManagerNames.forEach(viewManagerName => {
defineLazyObjectProperty(UIManager, viewManagerName, {
get: () => UIManager.getConstantsForViewManager(viewManagerName),

0 comments on commit 84affbd

Please sign in to comment.