Permalink
Browse files

remove hard dependency on JSGlobalContextRef in inspector interfaces

Differential Revision: D6385923

fbshipit-source-id: 2f547b0dc1760f72fa8d7edc67327415069c648e
  • Loading branch information...
bnham authored and facebook-github-bot committed Nov 27, 2017
1 parent 5f99b1a commit 850efa86508b19d800ff8cbdc725402c006db1a2
Showing with 2 additions and 4 deletions.
  1. +2 −4 ReactCommon/jschelpers/InspectorInterfaces.h
@@ -14,8 +14,6 @@
#include <string>
#include <vector>
#include <JavaScriptCore/JSBase.h>
namespace facebook {
namespace react {
@@ -46,8 +44,8 @@ class ILocalConnection : public IDestructible {
// Note: not destructible!
class IInspector {
public:
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, JSGlobalContextRef ctx) = 0;
virtual void unregisterGlobalContext(JSGlobalContextRef ctx) = 0;
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, void* ctx) = 0;
virtual void unregisterGlobalContext(void* ctx) = 0;
virtual std::vector<InspectorPage> getPages() const = 0;
virtual std::unique_ptr<ILocalConnection> connect(int pageId, std::unique_ptr<IRemoteConnection> remote) = 0;

0 comments on commit 850efa8

Please sign in to comment.