Permalink
Browse files

Custom build options: Move transform options into own property

Summary: Moves custom transform options into their own property when returning custom properties. This helps both transitioning to a `select` function as well as implementing RAM bundle support for the new buck integration

Reviewed By: jeanlauliac

Differential Revision: D5028075

fbshipit-source-id: 25fe3072023cc063deef537a12012d4bb3173579
  • Loading branch information...
davidaurelio authored and facebook-github-bot committed May 9, 2017
1 parent ffbb2a0 commit 8533c0d8162c635db46db51cb08b116545b02708
Showing with 8 additions and 5 deletions.
  1. +8 −5 packager/src/Bundler/index.js
@@ -53,11 +53,11 @@ export type BundlingOptions = {|
+transformer: JSTransformerOptions,
|};
export type ExtraTransformOptions = {|
+inlineRequires?: {+blacklist: {[string]: true}} | boolean,
export type ExtraTransformOptions = {
+preloadedModules?: {[path: string]: true} | false,
+ramGroups?: Array<string>,
|};
+transform?: {+inlineRequires?: {+blacklist: {[string]: true}} | boolean},
};
export type GetTransformOptionsOpts = {|
dev: boolean,
@@ -799,9 +799,12 @@ class Bundler {
.then(r => r.dependencies.map(d => d.path));
const {dev, hot, platform} = options;
const extraOptions = this._getTransformOptions
const extraOptions: ExtraTransformOptions = this._getTransformOptions
? await this._getTransformOptions(mainModuleName, {dev, hot, platform}, getDependencies)
: {};
const {transform = {}} = extraOptions;
return {
transformer: {
dev,
@@ -811,7 +814,7 @@ class Bundler {
dev,
generateSourceMaps: options.generateSourceMaps,
hot,
inlineRequires: extraOptions.inlineRequires || false,
inlineRequires: transform.inlineRequires || false,
platform,
projectRoot: options.projectRoots[0],
}

1 comment on commit 8533c0d

@henrikra

This comment has been minimized.

Show comment
Hide comment
@henrikra

henrikra Jun 8, 2017

Can someone show example on how to use this? Some usecase? :D

henrikra commented on 8533c0d Jun 8, 2017

Can someone show example on how to use this? Some usecase? :D

Please sign in to comment.