Permalink
Browse files

deprecate ReactFragmentActivity (#19741)

Summary:
Android Support Library page says https://developer.android.com/topic/libraries/support-library/
> Caution: Starting with Support Library release 26.0.0 (July 2017), the minimum supported API level across most support libraries has increased to Android 4.0 (API level 14) for most library packages. For more information, see Version Support and Package Names in this document.

_android.support.v4.app.FragmentActivity_ is used to support **Fragment**s on Android API versions below 11. Now, we support only API version 14 and above, it's ok to remove _ReactFragmentActivity_ that extends _FragmentActivity_.

Once ReactFragmentActivity removed, we can remove some codes that use _android.support.v4_ to work support _ReactFragmentActivity_ on **unsupported** Android versions.

CI is failing for unknown reasons: https://circleci.com/gh/dulmandakh/react-native/278
> Received 'killed' signal

Everything will build and work just fine, except showing _ ReactFragmentActivity_ as deprecated
Closes #19741

Differential Revision: D8454968

Pulled By: hramos

fbshipit-source-id: e5f901438ef764163af013fe854904a28c73070a
  • Loading branch information...
dulmandakh authored and hramos committed Jun 15, 2018
1 parent b4b0610 commit 8ea8dd6d48bc3db0b8255f320537e662e8fa2a09
Showing with 4 additions and 2 deletions.
  1. +4 −2 ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java
@@ -19,9 +19,11 @@
import com.facebook.react.modules.core.PermissionListener;
/**
* Base Activity for React Native applications. Like {@link ReactActivity} but extends
* {@link FragmentActivity} instead of {@link android.app.Activity}.
* @deprecated
* ReactFragmentActivity will be removed in 0.57 release.
* Use {@link ReactActivity} instead.
*/
@Deprecated
public abstract class ReactFragmentActivity extends FragmentActivity implements
DefaultHardwareBackBtnHandler, PermissionAwareActivity {

0 comments on commit 8ea8dd6

Please sign in to comment.