Skip to content
Permalink
Browse files

Rename dev settings menu preferences file as it conflicts with fennec…

…'s (#23123)

Summary:
On Android, resources with the same name from different libraries conflict, so it's encouraged to have prefixes for resource names.

This is one case where the settings menu preferences file in firefox for android is called `preferences.xml` so it conflicts with the dev support settings menu for react native.

when integrating react-native to the firefox project, react native dev settings menu never shows, and the one from firefox shows up instead.

This a link to a file from a fork project that I'm working on:
https://github.com/ghostery/browser-android/blob/master/mozilla-release/mobile/android/app/src/main/res/xml/preferences.xml

Please, let me know, if anything more needs to be changed

Changelog:
-----------
[Android] [Fixed] Rename dev settings menu preferences file with a RN prefix.
Pull Request resolved: #23123

Differential Revision: D13781836

Pulled By: cpojer

fbshipit-source-id: f27483d4eca5aa4148759b94b601673985c5aa91
  • Loading branch information...
khaled-cliqz authored and facebook-github-bot committed Jan 23, 2019
1 parent 803480a commit 9968d0c2030c1065979db34cc9a244bd52b7b2a5
@@ -23,6 +23,6 @@
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setTitle(getApplication().getResources().getString(R.string.catalyst_settings_title));
addPreferencesFromResource(R.xml.preferences);
addPreferencesFromResource(R.xml.rn_dev_preferences);
}
}

0 comments on commit 9968d0c

Please sign in to comment.
You can’t perform that action at this time.