Please sign in to comment.
Make RefreshControl properly controlled by JS
Summary: There was an issue with the way we made `RefreshControl` a controlled component when react doesn't render synchronously. This fixes the issue by using the same technique used in the commit 0cd2904 for`PickerAndroid` **Test plan (required)** Tested normal behaviour and tested that if not setting the `refreshing` prop to `true` during the `onRefresh` callback that the `RefreshControl` stops refreshing immediately. Also made sure that `setNativeProps` is only called if needed when the native refreshing state is not in sync with JS. Fix #7414 Closes #7445 Differential Revision: D3274981 fb-gh-sync-id: a1b9d46329f552984e33d11fa0e29ad6da689511 fbshipit-source-id: a1b9d46329f552984e33d11fa0e29ad6da689511
- Loading branch information...
Showing with 24 additions and 5 deletions.