Permalink
Browse files

Add gating to the JS delta client on the remote debugger

Reviewed By: jeanlauliac

Differential Revision: D5940923

fbshipit-source-id: 1ef4cd52ef3567f2e726217636253802a2e6bb40
  • Loading branch information...
rafeca authored and facebook-github-bot committed Sep 29, 2017
1 parent b3fc642 commit a0e88c2a5b3c7e585d6b2bd395fcd90898c8994b
@@ -14,8 +14,8 @@ const launchChrome = require('../util/launchChrome');
const {exec} = require('child_process');
function launchChromeDevTools(port) {
var debuggerURL = 'http://localhost:' + port + '/debugger-ui';
function launchChromeDevTools(port, args = '') {
var debuggerURL = 'http://localhost:' + port + '/debugger-ui' + args;
console.log('Launching Dev Tools...');
launchChrome(debuggerURL);
}
@@ -25,7 +25,10 @@ function escapePath(pathname) {
return '"' + pathname + '"';
}
function launchDevTools({port, projectRoots}, isChromeConnected) {
function launchDevTools(
{port, projectRoots, useDeltaBundler},
isChromeConnected,
) {
// Explicit config always wins
var customDebugger = process.env.REACT_DEBUGGER;
if (customDebugger) {
@@ -39,7 +42,7 @@ function launchDevTools({port, projectRoots}, isChromeConnected) {
});
} else if (!isChromeConnected()) {
// Dev tools are not yet open; we need to open a session
launchChromeDevTools(port);
launchChromeDevTools(port, useDeltaBundler ? '#useDeltaBundler' : '');
}
}
@@ -206,6 +206,10 @@
connectToDebuggerProxy();
async function getBlobUrl(url) {
if (window.location.hash.indexOf('useDeltaBundler') === -1) {
return url;
}
return await window.deltaUrlToBlobUrl(url.replace('.bundle', '.delta'));
}
})();

0 comments on commit a0e88c2

Please sign in to comment.