This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow overriding EditText construction in ReactTextInputShadowNode (#…
…27782) Summary: This PR makes it possible for subclasses of `ReactTextInputShadowNode` to control the construction of the "dummy" `EditText` instance that `ReactTextInputShadowNode` internally uses to determine the expected height of the view. This PR does not change the default behavior, it just opens up that default to being overriden. This is useful in the case of custom views that have different behavior from a "default" `EditText` instance (`new EditText(context)`). For example, it might have a different style applied. As a side benefit, this change also makes it easy to have subclasses not apply the default theme, which can allow the custom view to avoid a longstanding crash issue (#17530). ## Changelog [Android] [Added] - Allow overriding `EditText` construction in `ReactTextInputShadowNode` Pull Request resolved: #27782 Test Plan: All tests pass. Reviewed By: mdvacca Differential Revision: D19450593 Pulled By: JoshuaGross fbshipit-source-id: 8d2ce6117246fc3e2108623312b38583af5722b3
- Loading branch information
Showing 1 changed file with 14 additions and 6 deletions.