Permalink
Browse files

Fix build-break in legacy React bridge

Reviewed By: fromcelticpark

Differential Revision: D5479832

fbshipit-source-id: 764672a489216910a4646bfe9a798bf728cfe8dd
  • Loading branch information...
javache authored and facebook-github-bot committed Jul 24, 2017
1 parent 543cd21 commit a806e9035e1a4d923ce0a8674413856b89a673eb
Showing with 2 additions and 2 deletions.
  1. +2 −2 React/Executors/RCTJSCExecutor.mm
@@ -287,7 +287,7 @@ - (void)setUp
@"StartSamplingProfilerOnInit": @(self->_bridge.devSettings.startSamplingProfilerOnLaunch)
}, NULL).UTF8String);
}
contextRef = JSC_JSGlobalContextCreateInGroup(self->_useCustomJSCLibrary, nullptr, nullptr);
contextRef = JSC_JSGlobalContextCreateInGroup((bool)self->_useCustomJSCLibrary, nullptr, nullptr);
context = [JSC_JSContext(contextRef) contextWithJSGlobalContextRef:contextRef];
// We release the global context reference here to balance retainCount after JSGlobalContextCreateInGroup.
// The global context _is not_ going to be released since the JSContext keeps the strong reference to it.
@@ -963,7 +963,7 @@ - (void)_createContext
if (_useCustomJSCLibrary) {
JSC_configureJSCForIOS(true, "{}");
}
JSGlobalContextRef ctx = JSC_JSGlobalContextCreateInGroup(_useCustomJSCLibrary, nullptr, nullptr);
JSGlobalContextRef ctx = JSC_JSGlobalContextCreateInGroup((bool)_useCustomJSCLibrary, nullptr, nullptr);
_context = [JSC_JSContext(ctx) contextWithJSGlobalContextRef:ctx];
installBasicSynchronousHooksOnContext(_context);
dispatch_semaphore_signal(_semaphore);

0 comments on commit a806e90

Please sign in to comment.