Permalink
Browse files

Fix Navigator scene that is falsely collapsed.

Reviewed By: ericvicenti

Differential Revision: D4472405

fbshipit-source-id: 90022598f0fd8edfddc4460fee2338a7b67538c2
  • Loading branch information...
Hedger Wang authored and facebook-github-bot committed Jan 27, 2017
1 parent fc2936c commit a83af44a597fd6bfa760ee807c52c872ccb8448e
Showing with 1 addition and 0 deletions.
  1. +1 −0 Libraries/CustomComponents/Navigator/Navigator.js
@@ -1272,6 +1272,7 @@ var Navigator = React.createClass({
}
return (
<View
collapsable={false}
key={'scene_' + getRouteID(route)}
ref={(scene) => {
this._sceneRefs[i] = scene;

5 comments on commit a83af44

@rigdern

This comment has been minimized.

Show comment
Hide comment
@rigdern

rigdern Jan 27, 2017

Contributor

@hedgerwang @ericvicenti Why don't you want this View to be collapsed? I'm wondering if there's a more general category of things that shouldn't be collapsed or if this is really a one off edge case.

Contributor

rigdern replied Jan 27, 2017

@hedgerwang @ericvicenti Why don't you want this View to be collapsed? I'm wondering if there's a more general category of things that shouldn't be collapsed or if this is really a one off edge case.

@hedgerwang

This comment has been minimized.

Show comment
Hide comment
@hedgerwang

hedgerwang Jan 27, 2017

Contributor

@rigdern :

If the scene can be collapsed safely, it should be collapsed.

Unfortunately, a recent change 88eeea0
make it impossible to do it safely. I think this patch is just temporary to unbreak Navigator and we should have revisit the collapsing logics later.

Contributor

hedgerwang replied Jan 27, 2017

@rigdern :

If the scene can be collapsed safely, it should be collapsed.

Unfortunately, a recent change 88eeea0
make it impossible to do it safely. I think this patch is just temporary to unbreak Navigator and we should have revisit the collapsing logics later.

@rigdern

This comment has been minimized.

Show comment
Hide comment
@rigdern

rigdern Jan 27, 2017

Contributor

@hedgerwang How did 88eeea0 break Navigator? What kind of fix is in the works which will make your temporary Navigator commit unnecessary?

Contributor

rigdern replied Jan 27, 2017

@hedgerwang How did 88eeea0 break Navigator? What kind of fix is in the works which will make your temporary Navigator commit unnecessary?

@hedgerwang

This comment has been minimized.

Show comment
Hide comment
@hedgerwang

hedgerwang Jan 27, 2017

Contributor

@rigdern:

It broke one of our internal Android apps. The symptom is that a popped scene can't not remove its ViewNode and we saw ghost & orphaned view on the screen.

If view that actually has any contents / other style applied to it, it should not have been collapsed.
We have filed a separate task to investigate why the scene view is collapsed after 88eeea0 was landed.

Contributor

hedgerwang replied Jan 27, 2017

@rigdern:

It broke one of our internal Android apps. The symptom is that a popped scene can't not remove its ViewNode and we saw ghost & orphaned view on the screen.

If view that actually has any contents / other style applied to it, it should not have been collapsed.
We have filed a separate task to investigate why the scene view is collapsed after 88eeea0 was landed.

@hedgerwang

This comment has been minimized.

Show comment
Hide comment
@hedgerwang

hedgerwang Jan 27, 2017

Contributor

"What kind of fix is in the works which will make your temporary Navigator commit unnecessary?"
I'd leave the question to @javache .

Thanks.

Contributor

hedgerwang replied Jan 27, 2017

"What kind of fix is in the works which will make your temporary Navigator commit unnecessary?"
I'd leave the question to @javache .

Thanks.

Please sign in to comment.