Skip to content
Browse files
Android: Fix inconsistency with fractional TextInput padding
TextInput rounds padding down with `floor` when measuring. However, it rounds padding up with `ceil` when rendering.

This change makes things consistent by moving TextInput's rendering code to use `floor` as well. It looks like this is the intended behavior because commit bdff10b moved measuring from `ceil` to `floor`. It looks like TextInput's rendering code was just overlooked in that commit.

**Test plan (required)**

Verified TextInput padding works in a test app. Also, my team uses this change in our app.

Adam Comella
Microsoft Corp.
Closes #11003

Differential Revision: D4220855

Pulled By: mkonicek

fbshipit-source-id: 95349867ef89c021a8441b383a09052ca0dd569c
  • Loading branch information
Adam Comella authored and Facebook Github Bot committed Nov 22, 2016
1 parent 7e6ff74 commit aa85408f568ae9776fef99dcae317def0a07139a
Showing 1 changed file with 4 additions and 4 deletions.
@@ -164,10 +164,10 @@ public void updateExtraData(ReactEditText view, Object extraData) {
float[] padding = (float[]) extraData;

(int) Math.ceil(padding[0]),
(int) Math.ceil(padding[1]),
(int) Math.ceil(padding[2]),
(int) Math.ceil(padding[3]));
(int) Math.floor(padding[0]),
(int) Math.floor(padding[1]),
(int) Math.floor(padding[2]),
(int) Math.floor(padding[3]));
} else if (extraData instanceof ReactTextUpdate) {
ReactTextUpdate update = (ReactTextUpdate) extraData;
if (update.containsImages()) {

0 comments on commit aa85408

Please sign in to comment.