-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Android: Enable ad-hoc dependencies to be pre-downloaded
Summary: ReactAndroid/build.gradle downloads a number of ad-hoc dependencies from the internet such as boost, JSC headers, and folly. Having the build depend on the internet is problematic. For example, if the site hosting the JSC headers was to go down, then CI builds would start failing. This change introduces the environment variable REACT_NATIVE_DEPENDENCIES which refers to a path. Developers can pre-download all of the ad-hoc dependencies into that path and then the build process will grab the dependencies from that local path rather than trying to download them from the internet. This solution is in the spirit of the existing REACT_NATIVE_BOOST_PATH hook. **Test plan (required)** This change is used by my team's app. Adam Comella Microsoft Corp. Closes #11195 Differential Revision: D4247080 Pulled By: mkonicek fbshipit-source-id: 7c4350339c8d509a829e258d8f1bf320ff8eef64
- Loading branch information
Adam Comella
authored and
Facebook Github Bot
committed
Nov 29, 2016
1 parent
abf1438
commit aac8daf
Showing
1 changed file
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters