From b1356fe0d66cf1888a3d78e9cae7fc88a6e7ad3f Mon Sep 17 00:00:00 2001 From: Fabrizio Cucci Date: Tue, 10 Oct 2023 09:41:56 -0700 Subject: [PATCH] Remove stale task/comment in FabricUIManager (#40768) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/40768 The task referenced is 4 years old and it doesn't seem to be relevant anymore given that: * `addRootView` has been marked as deprecated * there is an explicit check in `addRootView` mentioning: > Do not call addRootView in Fabric; it is unsupported. Call startSurface instead Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D50122192 fbshipit-source-id: fe02d481b47663f5bdf4fb7527e480117f00be47 --- .../src/main/java/com/facebook/react/fabric/FabricUIManager.java | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index f21ef5af64ca6c..2f9a24fd3cdfe4 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -232,7 +232,6 @@ public FabricUIManager( mReactApplicationContext.registerComponentCallbacks(viewManagerRegistry); } - // TODO (T47819352): Rename this to startSurface for consistency with xplat/iOS @Override @UiThread @ThreadConfined(UI)