Please sign in to comment.
TimePickerDialogModule supports only FragmentActivity (#23372)
Summary: Now RN has only ReactActivity which extends AppCompatActivity, subclass of FragmentActivity, therefore no need to check if activity is FragmentActivity or not. This PR changes TimePickerDialogModule to work only with FragmentActivity. Also DialogFragment from Android is deprecated in API 28, and recommends to use DialogFragment from Support Library. Excerpt from DialogFragment documentation. > **This class was deprecated in API level 28.** > Use the Support Library DialogFragment for consistent behavior across all devices and access to Lifecycle. [Android] [Changed] - TimePickerDialogModule supports only FragmentActivity Pull Request resolved: #23372 Differential Revision: D14030748 Pulled By: cpojer fbshipit-source-id: 9b3778c90eb1c014260327513bc8709264b94431
- Loading branch information...
Showing with 18 additions and 86 deletions.
- +0 −48 ...tAndroid/src/main/java/com/facebook/react/modules/timepicker/SupportTimePickerDialogFragment.java
- +1 −2 ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/TimePickerDialogFragment.java
- +17 −36 ReactAndroid/src/main/java/com/facebook/react/modules/timepicker/TimePickerDialogModule.java
Oops, something went wrong.