Permalink
Browse files

`[RCTShadowView isHidden]` was removed

Summary:
It's unused.
Use `display` prop instead to control visiblity of the view.

Reviewed By: fkgozali

Differential Revision: D6888104

fbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd
  • Loading branch information...
shergin authored and facebook-github-bot committed Feb 6, 2018
1 parent 9dfa2e7 commit c19bc7968855e85758df9e1a47dc2a52e69668ed
Showing with 0 additions and 13 deletions.
  1. +0 −7 React/Modules/RCTUIManager.m
  2. +0 −6 React/Views/RCTShadowView.h
@@ -496,7 +496,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
UIUserInterfaceLayoutDirection layoutDirection;
BOOL isNew;
BOOL parentIsNew;
BOOL isHidden;
} RCTFrameData;
// Construct arrays then hand off to main thread
@@ -513,7 +512,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
shadowView.layoutDirection,
shadowView.isNewView,
shadowView.superview.isNewView,
shadowView.isHidden,
};
}
}
@@ -570,7 +568,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
UIView *view = viewRegistry[reactTag];
CGRect frame = frameData.frame;
BOOL isHidden = frameData.isHidden;
UIUserInterfaceLayoutDirection layoutDirection = frameData.layoutDirection;
BOOL isNew = frameData.isNew;
RCTLayoutAnimation *updatingLayoutAnimation = isNew ? nil : layoutAnimationGroup.updatingLayoutAnimation;
@@ -588,10 +585,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
}
};
if (view.isHidden != isHidden) {
view.hidden = isHidden;
}
if (view.reactLayoutDirection != layoutDirection) {
view.reactLayoutDirection = layoutDirection;
}
@@ -70,12 +70,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
*/
@property (nonatomic, assign, getter=isNewView) BOOL newView;
/**
* isHidden - RCTUIManager uses this to determine whether or not the UIView should be hidden. Useful if the
* ShadowView determines that its UIView will be clipped and wants to hide it.
*/
@property (nonatomic, assign, getter=isHidden) BOOL hidden;
/**
* Computed layout direction of the view.
*/

0 comments on commit c19bc79

Please sign in to comment.