Please sign in to comment.
Animated - Add missing super calls to fix native animated crash
Summary: There was some missing super.__detach calls in some Animated nodes, we rely on the base class being called to drop the node in the native implementation, not doing so will cause some nodes to leak. It also resulted in a crash when removing certain nodes because they would get updated after being detached. **Test plan** Reproduced the crash by unmounting a view that uses a DiffClamp node and made sure this fixes it. Also tested that other native animations still worked properly. Fixes #11317 Closes #12910 Differential Revision: D4718188 Pulled By: javache fbshipit-source-id: 179ec1334532152c124a9c0f447f488311925d0a
- Loading branch information...
Showing with 5 additions and 1 deletion.