Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update instructions for running on device
Summary: We no longer need to manually build JS bundle, everything should be integrated into Xcode. Closes #5521 Reviewed By: svcscm Differential Revision: D2860511 Pulled By: martinbigio fb-gh-sync-id: fdde6b39aabccd5a39c140d431acbbbe5af71ec4
- Loading branch information
Showing
1 changed file
with
4 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c49fc1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need instructions on how to create the offline bundle? For example is
react-native bundle --platform ios --dev false --entry-file index.ios.js --bundle-output iOS/main.jsbundle
no longer needed? Thanks.c49fc1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dabit3 you can still use that cli command if you want, for example, to create an offline bundle to distribute over-the-air or generate a source-map for 3rd party crash reporting service. But it is no longer required for typical app builds.