Please sign in to comment.
Fix run-ios when specifying a scheme as cli arg
Summary: The cli arg `--scheme` allows you to override the inferred scheme. The runOnDevice command takes this override into account, but run-ios doesn't. This commit fixes this discrepancy. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. Currently if a custom scheme is specified, `run-ios` will fail with the following message ``` Error: Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/AwesomeProject.app/Info.plist Print: Entry, ":CFBundleIdentifier", Does Not Exist ``` This PR fixes this. Tested manually from CLI. Closes #13548 Differential Revision: D4914531 Pulled By: javache fbshipit-source-id: 071710947e90e6194e0229751e33068565e010b2
- Loading branch information...