Please sign in to comment.
DatePickerDialogModule supports only FragmentActivity (#23371)
Summary: Now RN has only ReactActivity which extends AppCompatActivity, subclass of FragmentActivity, therefore no need to check if activity is FragmentActivity or not. This PR changes DatePickerDialogModule to work only with FragmentActivity. Also DialogFragment from Android is deprecated in API 28, and recommends to use DialogFragment from Support Library. Excerpt from DialogFragment documentation. > **This class was deprecated in API level 28.** > Use the Support Library DialogFragment for consistent behavior across all devices and access to Lifecycle. **BREAKING CHANGE**: Brown field apps must extend FragmentActivity or its subclasses [Android] [Changed] - DatePickerDialogModule supports only FragmentActivity Pull Request resolved: #23371 Differential Revision: D14030765 Pulled By: cpojer fbshipit-source-id: 3a1811102cf68b82c139f0e20b2fc8dab5d98b69
- Loading branch information...
Showing with 22 additions and 89 deletions.
- +1 −1 ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogFragment.java
- +21 −39 ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogModule.java
- +0 −49 ...tAndroid/src/main/java/com/facebook/react/modules/datepicker/SupportDatePickerDialogFragment.java
Oops, something went wrong.