Please sign in to comment.
Fix NativeAnimation invalidation & races on iOS
Summary: This diff attempts to fix a number of iOS native animation bugs related to improper node invalidation and a race with view creation. The major issues were presented in #9120 as problems 3 and 3b, but I'll recap here: The invalidation model we use is overly complicated and incomplete. The proper combination of `_needsUpdate` and `_hasUpdated` will result in nodes values being recomputed. However, we do not invalidate nodes in all the places we should, e.g. if we create a new view and attach it to an existing value node (see example in #9120). This diff chooses to remove the `_hasUpdated` flag, and simply relies on the `_needsUpdate` flag to mark a node as dirty. We mark nodes as dirty when they are: - created - updated - attached to new parents - detached from old parents - attached to a view Calling `updateNodeIfNecessary` will, if necessary, compute all invalidated parent values before recomputing the node value. It will then apply the update, and mark the no Closes #10663 Differential Revision: D4120301 Pulled By: mkonicek fbshipit-source-id: e247afcb5d8c15999b8328c664b9f7e764d76a75
- Loading branch information...
Showing with 611 additions and 388 deletions.
- +3 −3 Libraries/NativeAnimation/Drivers/RCTAnimationDriver.h
- +0 −5 Libraries/NativeAnimation/Drivers/RCTFrameAnimation.m
- +0 −5 Libraries/NativeAnimation/Drivers/RCTSpringAnimation.m
- +0 −6 Libraries/NativeAnimation/Nodes/RCTAnimatedNode.h
- +2 −17 Libraries/NativeAnimation/Nodes/RCTAnimatedNode.m
- +2 −2 Libraries/NativeAnimation/Nodes/RCTPropsAnimatedNode.h
- +32 −25 Libraries/NativeAnimation/Nodes/RCTPropsAnimatedNode.m
- +1 −1 Libraries/NativeAnimation/Nodes/RCTStyleAnimatedNode.h
- +7 −13 Libraries/NativeAnimation/Nodes/RCTStyleAnimatedNode.m
- +1 −1 Libraries/NativeAnimation/Nodes/RCTTransformAnimatedNode.h
- +6 −12 Libraries/NativeAnimation/Nodes/RCTTransformAnimatedNode.m
- +8 −0 Libraries/NativeAnimation/RCTAnimation.xcodeproj/project.pbxproj
- +1 −0 Libraries/NativeAnimation/RCTNativeAnimatedModule.h
- +87 −284 Libraries/NativeAnimation/RCTNativeAnimatedModule.m
- +82 −0 Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h
- +360 −0 Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m
- +2 −2 Libraries/NativeAnimation/RCTViewPropertyMapper.h
- +17 −12 Libraries/NativeAnimation/RCTViewPropertyMapper.m
Oops, something went wrong.