Permalink
Browse files

Remove experimental shouldBridgeInitializeNativeModulesSynchronously:

Differential Revision: D6124035

fbshipit-source-id: 540b8bfc955bf48e9ca33ed97807177ac740059e
  • Loading branch information...
danzimm authored and facebook-github-bot committed Oct 25, 2017
1 parent a32e1cf commit ca85a536c63ba6fd03d2c91a4d9cf2d15aa3157d
Showing with 0 additions and 14 deletions.
  1. +0 −2 React/Base/RCTBatchedBridge.mm
  2. +0 −10 React/Base/RCTBridgeDelegate.h
  3. +0 −2 React/CxxBridge/RCTCxxBridge.mm
@@ -410,8 +410,6 @@ - (void)prepareModulesWithDispatchGroup:(dispatch_group_t)dispatchGroup
// We better be on the right thread too.
RCTAssertMainQueue();
initializeImmediately = YES;
} else if ([self.delegate respondsToSelector:@selector(shouldBridgeInitializeNativeModulesSynchronously:)]) {
initializeImmediately = [self.delegate shouldBridgeInitializeNativeModulesSynchronously:self];
}
// Set up modules that require main thread init or constants export
@@ -63,16 +63,6 @@
*/
- (BOOL)shouldBridgeLoadJavaScriptSynchronously:(RCTBridge *)bridge;
/**
* When initializing native modules that require main thread initialization, the bridge
* will default to dispatch module creation blocks asynchrously. If we're blockingly
* waiting on the main thread to finish bridge creation on the main thread, this will
* deadlock. Override this method to initialize modules synchronously instead.
*
* @experimental
*/
- (BOOL)shouldBridgeInitializeNativeModulesSynchronously:(RCTBridge *)bridge;
/**
* Configure whether the JSCExecutor created should use the system JSC API or
* alternative hooks provided. When returning YES from this method, you must have
@@ -725,8 +725,6 @@ - (void)_prepareModulesWithDispatchGroup:(dispatch_group_t)dispatchGroup
// We better be on the right thread too.
RCTAssertMainQueue();
initializeImmediately = YES;
} else if ([self.delegate respondsToSelector:@selector(shouldBridgeInitializeNativeModulesSynchronously:)]) {
initializeImmediately = [self.delegate shouldBridgeInitializeNativeModulesSynchronously:self];
}
// Set up modules that require main thread init or constants export

0 comments on commit ca85a53

Please sign in to comment.