Please sign in to comment.
Removing our own implementation of round-to-pixel algorithm
Summary: > Okay, I don't remember where we first met > But hey, admitting is the first step This issue has a looong history. The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!) The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK. For now, the vision is clear: * The basic algorithm should live in Yoga for unification and performance reasons. * We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout. * We have to enable it in RN eventually. So, this is the first step: Removing old, broken code which we don't plan to fix and use. Make React Native crisp again! Reviewed By: fkgozali Differential Revision: D6888662 fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
- Loading branch information...