Permalink
Browse files

check for GET and Head in send request

Summary:
React Native had an underlying problem connecting to Firestore (Google's latest database) from Android devices. You can follow the issue [here](firebase/firebase-js-sdk#283).
The main problem was in NetworkingModule.java. Please refer to section 3 of 4.5.6 in whatwg.org's guideline https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send

In this [video](https://www.youtube.com/watch?v=tILagf46ys8), I am showing how the react native behaved before adding the new fix and how it worked after the new fix added.  The new fix starts at 50 seconds.

[ANDROID] [BUGFIX] [FIRESTORE][XMLHttpRequest][ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java] - Fixes the connection to Firestore by following whatwg.org's XMLHttpRequest send() method
Closes #17940

Differential Revision: D7173468

Pulled By: hramos

fbshipit-source-id: 354d36f03d611889073553b93a7c43c6d4363ff3
  • Loading branch information...
samsafay authored and facebook-github-bot committed Mar 7, 2018
1 parent 6fc4163 commit d52569c4a1b6bd19792e4bda23e3a8c3ac4ad8df
@@ -348,7 +348,7 @@ public void onProgress(long bytesWritten, long contentLength, boolean done) {
}
RequestBody requestBody;
if (data == null) {
if (data == null || method.toLowerCase().equals("get") || method.toLowerCase().equals("head")) {
requestBody = RequestBodyUtil.getEmptyBody(method);
} else if (handler != null) {
requestBody = handler.toRequestBody(data, contentType);

0 comments on commit d52569c

Please sign in to comment.